pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
6+ messages / 1 participants
[nested] [flat]

* pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
@ 2022-05-09 15:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-09 15:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "Disallow infinite endpoints in generate_series() for timestamps."

This reverts commit eafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
and its back-branch counterparts.  Corey Huinker pointed out that
we'd discussed this exact change back in 2016 and rejected it,
on the grounds that there's at least one usage pattern with LIMIT
where an infinite endpoint can usefully be used.  Perhaps that
argument needs to be re-litigated, but there's no time left before
our back-branch releases.  To keep our options open, restore the
status quo ante; if we do end up deciding to change things, waiting
one more quarter won't hurt anything.

Rather than just doing a straight revert, I added a new test case
demonstrating the usage with LIMIT.  That'll at least remind us of
the issue if we forget again.

Discussion: https://postgr.es/m/3603504.1652068977@sss.pgh.pa.us
Discussion: https://postgr.es/m/CADkLM=dzw0Pvdqp5yWKxMd+VmNkAMhG=4ku7GnCZxebWnzmz3Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/29904f5f2fdafbbb96ef3685fd361053b061aeb1

Modified Files
--------------
src/backend/utils/adt/timestamp.c         | 28 ----------------------------
src/test/regress/expected/timestamp.out   | 27 +++++++++++++++++++--------
src/test/regress/expected/timestamptz.out | 27 +++++++++++++++++++--------
src/test/regress/sql/timestamp.sql        | 11 +++++------
src/test/regress/sql/timestamptz.sql      | 11 +++++------
5 files changed, 48 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
@ 2022-05-09 15:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-09 15:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "Disallow infinite endpoints in generate_series() for timestamps."

This reverts commit eafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
and its back-branch counterparts.  Corey Huinker pointed out that
we'd discussed this exact change back in 2016 and rejected it,
on the grounds that there's at least one usage pattern with LIMIT
where an infinite endpoint can usefully be used.  Perhaps that
argument needs to be re-litigated, but there's no time left before
our back-branch releases.  To keep our options open, restore the
status quo ante; if we do end up deciding to change things, waiting
one more quarter won't hurt anything.

Rather than just doing a straight revert, I added a new test case
demonstrating the usage with LIMIT.  That'll at least remind us of
the issue if we forget again.

Discussion: https://postgr.es/m/3603504.1652068977@sss.pgh.pa.us
Discussion: https://postgr.es/m/CADkLM=dzw0Pvdqp5yWKxMd+VmNkAMhG=4ku7GnCZxebWnzmz3Q@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9b5797ca54f5ad74740220c1be070eda4c21c82c

Modified Files
--------------
src/backend/utils/adt/timestamp.c         | 28 ----------------------------
src/test/regress/expected/timestamp.out   | 27 +++++++++++++++++++--------
src/test/regress/expected/timestamptz.out | 27 +++++++++++++++++++--------
src/test/regress/sql/timestamp.sql        | 11 +++++------
src/test/regress/sql/timestamptz.sql      | 11 +++++------
5 files changed, 48 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
@ 2022-05-09 15:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-09 15:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "Disallow infinite endpoints in generate_series() for timestamps."

This reverts commit eafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
and its back-branch counterparts.  Corey Huinker pointed out that
we'd discussed this exact change back in 2016 and rejected it,
on the grounds that there's at least one usage pattern with LIMIT
where an infinite endpoint can usefully be used.  Perhaps that
argument needs to be re-litigated, but there's no time left before
our back-branch releases.  To keep our options open, restore the
status quo ante; if we do end up deciding to change things, waiting
one more quarter won't hurt anything.

Rather than just doing a straight revert, I added a new test case
demonstrating the usage with LIMIT.  That'll at least remind us of
the issue if we forget again.

Discussion: https://postgr.es/m/3603504.1652068977@sss.pgh.pa.us
Discussion: https://postgr.es/m/CADkLM=dzw0Pvdqp5yWKxMd+VmNkAMhG=4ku7GnCZxebWnzmz3Q@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7f0754bc4c0a0abadcbe02e886e31305c37a7053

Modified Files
--------------
src/backend/utils/adt/timestamp.c         | 28 ----------------------------
src/test/regress/expected/timestamp.out   | 27 +++++++++++++++++++--------
src/test/regress/expected/timestamptz.out | 27 +++++++++++++++++++--------
src/test/regress/sql/timestamp.sql        | 11 +++++------
src/test/regress/sql/timestamptz.sql      | 11 +++++------
5 files changed, 48 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
@ 2022-05-09 15:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-09 15:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "Disallow infinite endpoints in generate_series() for timestamps."

This reverts commit eafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
and its back-branch counterparts.  Corey Huinker pointed out that
we'd discussed this exact change back in 2016 and rejected it,
on the grounds that there's at least one usage pattern with LIMIT
where an infinite endpoint can usefully be used.  Perhaps that
argument needs to be re-litigated, but there's no time left before
our back-branch releases.  To keep our options open, restore the
status quo ante; if we do end up deciding to change things, waiting
one more quarter won't hurt anything.

Rather than just doing a straight revert, I added a new test case
demonstrating the usage with LIMIT.  That'll at least remind us of
the issue if we forget again.

Discussion: https://postgr.es/m/3603504.1652068977@sss.pgh.pa.us
Discussion: https://postgr.es/m/CADkLM=dzw0Pvdqp5yWKxMd+VmNkAMhG=4ku7GnCZxebWnzmz3Q@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5045c795301d6332660053f0b4194adac03a6db5

Modified Files
--------------
src/backend/utils/adt/timestamp.c         | 28 ----------------------------
src/test/regress/expected/timestamp.out   | 27 +++++++++++++++++++--------
src/test/regress/expected/timestamptz.out | 27 +++++++++++++++++++--------
src/test/regress/sql/timestamp.sql        | 11 +++++------
src/test/regress/sql/timestamptz.sql      | 11 +++++------
5 files changed, 48 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
@ 2022-05-09 15:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-09 15:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "Disallow infinite endpoints in generate_series() for timestamps."

This reverts commit eafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
and its back-branch counterparts.  Corey Huinker pointed out that
we'd discussed this exact change back in 2016 and rejected it,
on the grounds that there's at least one usage pattern with LIMIT
where an infinite endpoint can usefully be used.  Perhaps that
argument needs to be re-litigated, but there's no time left before
our back-branch releases.  To keep our options open, restore the
status quo ante; if we do end up deciding to change things, waiting
one more quarter won't hurt anything.

Rather than just doing a straight revert, I added a new test case
demonstrating the usage with LIMIT.  That'll at least remind us of
the issue if we forget again.

Discussion: https://postgr.es/m/3603504.1652068977@sss.pgh.pa.us
Discussion: https://postgr.es/m/CADkLM=dzw0Pvdqp5yWKxMd+VmNkAMhG=4ku7GnCZxebWnzmz3Q@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c0406fa768edd6b9e4bb543b04c871cd80f03934

Modified Files
--------------
src/backend/utils/adt/timestamp.c         | 28 ----------------------------
src/test/regress/expected/timestamp.out   | 27 +++++++++++++++++++--------
src/test/regress/expected/timestamptz.out | 27 +++++++++++++++++++--------
src/test/regress/sql/timestamp.sql        | 11 +++++------
src/test/regress/sql/timestamptz.sql      | 11 +++++------
5 files changed, 48 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Revert "Disallow infinite endpoints in generate_series() for tim
@ 2022-05-09 15:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2022-05-09 15:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Revert "Disallow infinite endpoints in generate_series() for timestamps."

This reverts commit eafdf9de06e9b60168f5e47cedcfceecdc6d4b5f
and its back-branch counterparts.  Corey Huinker pointed out that
we'd discussed this exact change back in 2016 and rejected it,
on the grounds that there's at least one usage pattern with LIMIT
where an infinite endpoint can usefully be used.  Perhaps that
argument needs to be re-litigated, but there's no time left before
our back-branch releases.  To keep our options open, restore the
status quo ante; if we do end up deciding to change things, waiting
one more quarter won't hurt anything.

Rather than just doing a straight revert, I added a new test case
demonstrating the usage with LIMIT.  That'll at least remind us of
the issue if we forget again.

Discussion: https://postgr.es/m/3603504.1652068977@sss.pgh.pa.us
Discussion: https://postgr.es/m/CADkLM=dzw0Pvdqp5yWKxMd+VmNkAMhG=4ku7GnCZxebWnzmz3Q@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/86a21803c7d860bd0cbd8c81c34cc9250d4cc173

Modified Files
--------------
src/backend/utils/adt/timestamp.c         | 28 ----------------------------
src/test/regress/expected/timestamp.out   | 27 +++++++++++++++++++--------
src/test/regress/expected/timestamptz.out | 27 +++++++++++++++++++--------
src/test/regress/sql/timestamp.sql        | 11 +++++------
src/test/regress/sql/timestamptz.sql      | 11 +++++------
5 files changed, 48 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2022-05-09 15:41 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 15:41 pgsql: Revert "Disallow infinite endpoints in generate_series() for tim Tom Lane <tgl@sss.pgh.pa.us>
2022-05-09 15:41 pgsql: Revert "Disallow infinite endpoints in generate_series() for tim Tom Lane <tgl@sss.pgh.pa.us>
2022-05-09 15:41 pgsql: Revert "Disallow infinite endpoints in generate_series() for tim Tom Lane <tgl@sss.pgh.pa.us>
2022-05-09 15:41 pgsql: Revert "Disallow infinite endpoints in generate_series() for tim Tom Lane <tgl@sss.pgh.pa.us>
2022-05-09 15:41 pgsql: Revert "Disallow infinite endpoints in generate_series() for tim Tom Lane <tgl@sss.pgh.pa.us>
2022-05-09 15:41 pgsql: Revert "Disallow infinite endpoints in generate_series() for tim Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox