pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. 6+ messages / 1 participants [nested] [flat]
* pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. @ 2022-05-10 22:42 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-05-10 22:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if there are multiple OpenLDAP versions visible, as is likely to be the case on macOS in particular. We'd end up using shiny new libldap in the backend and a hoary libldap_r in libpq. Instead, once we've found libldap, check if it's >= 2.5 (by probing for a function introduced then) and don't bother looking for libldap_r if so. While one can imagine library setups that this'd still give the wrong answer for, they seem unlikely to occur in practice. Per report from Peter Eisentraut. Back-patch to all supported branches. Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/aff45c879e018d18951a9bc4cd8e2a395ee52c43 Modified Files -------------- configure | 13 ++++++++++++- configure.ac | 9 ++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. @ 2022-05-10 22:42 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-05-10 22:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if there are multiple OpenLDAP versions visible, as is likely to be the case on macOS in particular. We'd end up using shiny new libldap in the backend and a hoary libldap_r in libpq. Instead, once we've found libldap, check if it's >= 2.5 (by probing for a function introduced then) and don't bother looking for libldap_r if so. While one can imagine library setups that this'd still give the wrong answer for, they seem unlikely to occur in practice. Per report from Peter Eisentraut. Back-patch to all supported branches. Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/af9b967671533965debc9caf3e20fd65a3c71ae4 Modified Files -------------- configure | 13 ++++++++++++- configure.in | 9 ++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. @ 2022-05-10 22:42 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-05-10 22:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if there are multiple OpenLDAP versions visible, as is likely to be the case on macOS in particular. We'd end up using shiny new libldap in the backend and a hoary libldap_r in libpq. Instead, once we've found libldap, check if it's >= 2.5 (by probing for a function introduced then) and don't bother looking for libldap_r if so. While one can imagine library setups that this'd still give the wrong answer for, they seem unlikely to occur in practice. Per report from Peter Eisentraut. Back-patch to all supported branches. Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c61f36d9960664a044269f4dcb1a6ad42470a078 Modified Files -------------- configure | 13 ++++++++++++- configure.in | 9 ++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. @ 2022-05-10 22:42 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-05-10 22:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if there are multiple OpenLDAP versions visible, as is likely to be the case on macOS in particular. We'd end up using shiny new libldap in the backend and a hoary libldap_r in libpq. Instead, once we've found libldap, check if it's >= 2.5 (by probing for a function introduced then) and don't bother looking for libldap_r if so. While one can imagine library setups that this'd still give the wrong answer for, they seem unlikely to occur in practice. Per report from Peter Eisentraut. Back-patch to all supported branches. Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/36d76da8156a01073e805f90b5e861415dfb13b5 Modified Files -------------- configure | 13 ++++++++++++- configure.in | 9 ++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. @ 2022-05-10 22:42 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-05-10 22:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if there are multiple OpenLDAP versions visible, as is likely to be the case on macOS in particular. We'd end up using shiny new libldap in the backend and a hoary libldap_r in libpq. Instead, once we've found libldap, check if it's >= 2.5 (by probing for a function introduced then) and don't bother looking for libldap_r if so. While one can imagine library setups that this'd still give the wrong answer for, they seem unlikely to occur in practice. Per report from Peter Eisentraut. Back-patch to all supported branches. Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8ed13fb9346dfcf4423a40cc740b247463340342 Modified Files -------------- configure | 13 ++++++++++++- configure.in | 9 ++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. @ 2022-05-10 22:42 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2022-05-10 22:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if there are multiple OpenLDAP versions visible, as is likely to be the case on macOS in particular. We'd end up using shiny new libldap in the backend and a hoary libldap_r in libpq. Instead, once we've found libldap, check if it's >= 2.5 (by probing for a function introduced then) and don't bother looking for libldap_r if so. While one can imagine library setups that this'd still give the wrong answer for, they seem unlikely to occur in practice. Per report from Peter Eisentraut. Back-patch to all supported branches. Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/12736e7dc326c404ae0f12ebdf5d1dbb954ec5f6 Modified Files -------------- configure | 13 ++++++++++++- configure.ac | 9 ++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-05-10 22:42 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-05-10 22:42 pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. Tom Lane <tgl@sss.pgh.pa.us> 2022-05-10 22:42 pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. Tom Lane <tgl@sss.pgh.pa.us> 2022-05-10 22:42 pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. Tom Lane <tgl@sss.pgh.pa.us> 2022-05-10 22:42 pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. Tom Lane <tgl@sss.pgh.pa.us> 2022-05-10 22:42 pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. Tom Lane <tgl@sss.pgh.pa.us> 2022-05-10 22:42 pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox