pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.
Date: Tue, 10 May 2022 22:42:28 +0000
Message-ID: <E1noYYm-0004TQ-74@gemulon.postgresql.org> (raw)

configure: don't probe for libldap_r if libldap is 2.5 or newer.

In OpenLDAP 2.5 and later, libldap itself is always thread-safe and
there's never a libldap_r.  Our existing coding dealt with that
by assuming it wouldn't find libldap_r if libldap is thread-safe.
But that rule fails to cope if there are multiple OpenLDAP versions
visible, as is likely to be the case on macOS in particular.  We'd
end up using shiny new libldap in the backend and a hoary libldap_r
in libpq.

Instead, once we've found libldap, check if it's >= 2.5 (by
probing for a function introduced then) and don't bother looking
for libldap_r if so.  While one can imagine library setups that
this'd still give the wrong answer for, they seem unlikely to
occur in practice.

Per report from Peter Eisentraut.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/af9b967671533965debc9caf3e20fd65a3c71ae4

Modified Files
--------------
configure    | 13 ++++++++++++-
configure.in |  9 ++++++++-
2 files changed, 20 insertions(+), 2 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1noYYm-0004TQ-74@gemulon.postgresql.org>
Permalink:  ../E1noYYm-0004TQ-74@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1noYYm-0004TQ-74@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.
  In-Reply-To: <E1noYYm-0004TQ-74@gemulon.postgresql.org>
  References: <E1noYYm-0004TQ-74@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox