pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add a new shmem_request_hook hook.
Date: Fri, 13 May 2022 13:49:36 +0000
Message-ID: <E1npVfj-000WBN-PS@gemulon.postgresql.org> (raw)

Add a new shmem_request_hook hook.

Currently, preloaded libraries are expected to request additional
shared memory and LWLocks in _PG_init().  However, it is not unusal
for such requests to depend on MaxBackends, which won't be
initialized at that time.  Such requests could also depend on GUCs
that other modules might change.  This introduces a new hook where
modules can safely use MaxBackends and GUCs to request additional
shared memory and LWLocks.

Furthermore, this change restricts requests for shared memory and
LWLocks to this hook.  Previously, libraries could make requests
until the size of the main shared memory segment was calculated.
Unlike before, we no longer silently ignore requests received at
invalid times.  Instead, we FATAL if someone tries to request
additional shared memory or LWLocks outside of the hook.

Nathan Bossart and Julien Rouhaud

Discussion: https://postgr.es/m/20220412210112.GA2065815%40nathanxps13
Discussion: https://postgr.es/m/Yn2jE/lmDhKtkUdr@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4f2400cb3f10aa79f99fba680c198237da28dd38

Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c                | 17 +++++++++++++++-
contrib/pg_stat_statements/pg_stat_statements.c | 26 +++++++++++++++++--------
doc/src/sgml/xfunc.sgml                         | 12 ++++++++++--
src/backend/postmaster/postmaster.c             |  5 +++++
src/backend/storage/ipc/ipci.c                  | 20 ++++++-------------
src/backend/storage/lmgr/lwlock.c               | 18 +++++------------
src/backend/utils/init/miscinit.c               | 15 ++++++++++++++
src/include/miscadmin.h                         |  5 +++++
src/tools/pgindent/typedefs.list                |  1 +
9 files changed, 81 insertions(+), 38 deletions(-)



Message-ID: <E1npVfj-000WBN-PS@gemulon.postgresql.org>
Permalink:  ../E1npVfj-000WBN-PS@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1npVfj-000WBN-PS@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Add a new shmem_request_hook hook.
  In-Reply-To: <E1npVfj-000WBN-PS@gemulon.postgresql.org>
  References: <E1npVfj-000WBN-PS@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox