pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix slow animal timeouts in 032_relfilenode_reuse.pl.
Date: Sat, 14 May 2022 00:06:41 +0000
Message-ID: <E1npfIu-000ahY-TN@gemulon.postgresql.org> (raw)

Fix slow animal timeouts in 032_relfilenode_reuse.pl.

Per BF animal chipmunk:  CREATE DATABASE could apparently fail due to an
AV process being in the template database and not quitting fast enough
for the 5 second timeout in CountOtherDBBackends().  The test script had
autovacuum_naptime=1s to encourage more activity and opening of fds, but
that wasn't strictly necessary for this test.  Take it out.

Per BF animal skink:  there was a 300s timeout for all tests in the
script, but apparently that was not enough under valgrind.  Let's use
the standard timeout $PostgreSQL::Test::Utils::timeout_default, but
restart it for each query we run.

Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://postgr.es/m/CA%2BhUKGKa8HNJaA24gqiiFoGy0ysndeVoJsHvX_q1-DVLFaGAmw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/93759c665d482b5bf76ca22c9cac91e713e9386e

Modified Files
--------------
src/test/recovery/t/032_relfilenode_reuse.pl | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)



Message-ID: <E1npfIu-000ahY-TN@gemulon.postgresql.org>
Permalink:  ../E1npfIu-000ahY-TN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1npfIu-000ahY-TN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Fix slow animal timeouts in 032_relfilenode_reuse.pl.
  In-Reply-To: <E1npfIu-000ahY-TN@gemulon.postgresql.org>
  References: <E1npfIu-000ahY-TN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox