pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_waldump: Improve option parsing error messages
Date: Fri, 20 May 2022 07:45:10 +0000
Message-ID: <E1nrxJu-000F8d-Gd@gemulon.postgresql.org> (raw)

pg_waldump: Improve option parsing error messages

I rephrased the error messages to be more in the style of
option_parse_int(), and also made use of the new "detail" message
facility.  I didn't actually use option_parse_int() (which could be
used for -n) because libpgfeutils wasn't used here yet and I wanted to
keep this just to string changes.  But it could be done in the future.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/25f915b31e41e5c86e1905d199c7d41cc66161ed

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)



Message-ID: <E1nrxJu-000F8d-Gd@gemulon.postgresql.org>
Permalink:  ../E1nrxJu-000F8d-Gd@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nrxJu-000F8d-Gd@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: pg_waldump: Improve option parsing error messages
  In-Reply-To: <E1nrxJu-000F8d-Gd@gemulon.postgresql.org>
  References: <E1nrxJu-000F8d-Gd@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox