From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove portability hazard in unsafe_tests/sql/guc_privs.sql.
Date: Fri, 20 May 2022 17:42:29 +0000
Message-ID: <E1ns6dx-000JRd-7j@gemulon.postgresql.org> (raw)
Remove portability hazard in unsafe_tests/sql/guc_privs.sql.
This new-in-v15 test case assumed it could set max_stack_depth as high
as 2MB. You might think that'd be true on any modern platform but
you'd be wrong, as I found out while experimenting with NetBSD/hppa.
This test is about privileges not platform capabilities, so there seems
no need to use any value greater than the 100kB setting already used
in a couple of places in the core regression tests. There's certainly
no call to expect people to raise their platform's default ulimit just
to run this test.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5e5fa323350060360799004f96840bbf3cb51e49
Modified Files
--------------
src/test/modules/unsafe_tests/expected/guc_privs.out | 4 ++--
src/test/modules/unsafe_tests/sql/guc_privs.sql | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Remove portability hazard in unsafe_tests/sql/guc_privs.sql.
In-Reply-To: <E1ns6dx-000JRd-7j@gemulon.postgresql.org>
References: <E1ns6dx-000JRd-7j@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox