pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve and fix some issues in the TAP tests of pg_upgrade
Date: Sat, 21 May 2022 03:02:43 +0000
Message-ID: <E1nsFO6-000NHq-WD@gemulon.postgresql.org> (raw)

Improve and fix some issues in the TAP tests of pg_upgrade

This is based on a set of suggestions from Noah, with the following
changes made:
- The set of databases created in the tests are now prefixed with
"regression" to not trigger any warnings with name restrictions when
compiling the code with -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS, and
now only the first name checks after the Windows case of double quotes
mixed with backslashes.
- Fix an issue with EXTRA_REGRESS_OPTS, which were not processed in a
way consistent with 027_stream_regress.pl (missing space between the
option string and pg_regress).  This got introduced in 7dd3ee5.
- Add a check on the exit code of the pg_regress command, to catch
failures after running the regression tests.

Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/YoHhWD5vQzb2mmiF@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eaa5ebe046c4f247d843bdfd36da4c28be9dbfab

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)



Message-ID: <E1nsFO6-000NHq-WD@gemulon.postgresql.org>
Permalink:  ../E1nsFO6-000NHq-WD@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nsFO6-000NHq-WD@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Improve and fix some issues in the TAP tests of pg_upgrade
  In-Reply-To: <E1nsFO6-000NHq-WD@gemulon.postgresql.org>
  References: <E1nsFO6-000NHq-WD@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox