pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstat: fix stats.spec instability on slow machines.
Date: Sun, 22 May 2022 22:28:50 +0000
Message-ID: <E1nsu49-000f8q-R9@gemulon.postgresql.org> (raw)

pgstat: fix stats.spec instability on slow machines.

On slow machines the modified test could end up switching the order in which
transactional stats are reported in one session and non-transactional stats in
another session. As stats handling of truncate is implemented as setting
live/dead rows 0, the order in which a truncate's stats changes are applied,
relative to normal stats updates, matters. The handling of stats for truncate
hasn't changed due to shared memory stats, this is longstanding behavior.

We might want to improve truncate's stats handling in the future, but for now
just change the order of forced flushed to make the test stable.

Reported-By: Christoph Berg <myon@debian.org>
Discussion: https://postgr.es/m/YoZf7U/WmfmFYFEx@msg.df7cb.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7fdbdf204920ac279f280d0a8e96946fdaf41aef

Modified Files
--------------
src/test/isolation/expected/stats.out   | 4 ++--
src/test/isolation/expected/stats_1.out | 6 +++---
src/test/isolation/specs/stats.spec     | 3 ++-
3 files changed, 7 insertions(+), 6 deletions(-)



Message-ID: <E1nsu49-000f8q-R9@gemulon.postgresql.org>
Permalink:  ../E1nsu49-000f8q-R9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nsu49-000f8q-R9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: pgstat: fix stats.spec instability on slow machines.
  In-Reply-To: <E1nsu49-000f8q-R9@gemulon.postgresql.org>
  References: <E1nsu49-000f8q-R9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox