pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Handle NULL for short descriptions of custom GUC variables
Date: Sat, 28 May 2022 03:13:40 +0000
Message-ID: <E1numtY-001UMO-8Z@gemulon.postgresql.org> (raw)

Handle NULL for short descriptions of custom GUC variables

If a short description is specified as NULL in one of the various
DefineCustomXXXVariable() functions available to external modules to
define a custom parameter, SHOW ALL would crash.  This change teaches
SHOW ALL to properly handle NULL short descriptions, as well as any code
paths that manipulate it, to gain in flexibility.  Note that
help_config.c was already able to do that, when describing a set of GUCs
for postgres --describe-config.

Author: Steve Chavez
Reviewed by: Nathan Bossart, Andres Freund, Michael Paquier, Tom Lane
Discussion: https://postgr.es/m/CAGRrpzY6hO-Kmykna_XvsTv8P2DshGiU6G3j8yGao4mk0CqjHA%40mail.gmail.com
Backpatch-through: 10

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f1431f3bffa00962ae8debb98a750ed2fb09fa3b

Modified Files
--------------
src/backend/utils/misc/guc.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1numtY-001UMO-8Z@gemulon.postgresql.org>
Permalink:  ../E1numtY-001UMO-8Z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1numtY-001UMO-8Z@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Handle NULL for short descriptions of custom GUC variables
  In-Reply-To: <E1numtY-001UMO-8Z@gemulon.postgresql.org>
  References: <E1numtY-001UMO-8Z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox