pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove useless tests for TRUNCATE on foreign tables
Date: Tue, 31 May 2022 00:48:49 +0000
Message-ID: <E1nvq40-001wwI-OJ@gemulon.postgresql.org> (raw)

Remove useless tests for TRUNCATE on foreign tables

foreign_data has kept around a set of tests for TRUNCATE to look after
the case of foreign tables, with[out] inheritance and with[out]
partitions, assuming that the command is not supported for this relkind.
However, TRUNCATE is supported on foreign tables if the FDW involved is
able to handle the command, like postgres_fdw.

Note that postgres_fdw includes tests to cover all the cases removed by
this commit (which had misleading comments), so these did not provide
any additional coverage anyway.

Author: Yugo Nagata
Discussion: https://postgr.es/m/20220527172543.0a2fdb469cf048b81c0967d3@sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0efa51357e0fe0fd69f0c27245ed7e68039b1ea8

Modified Files
--------------
src/test/regress/expected/foreign_data.out | 10 ----------
src/test/regress/sql/foreign_data.sql      |  8 --------
2 files changed, 18 deletions(-)



Message-ID: <E1nvq40-001wwI-OJ@gemulon.postgresql.org>
Permalink:  ../E1nvq40-001wwI-OJ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nvq40-001wwI-OJ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Remove useless tests for TRUNCATE on foreign tables
  In-Reply-To: <E1nvq40-001wwI-OJ@gemulon.postgresql.org>
  References: <E1nvq40-001wwI-OJ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox