pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert changes to CONCURRENTLY that "sped up" Xmin advance
Date: Tue, 31 May 2022 19:25:52 +0000
Message-ID: <E1nw7V2-0024eb-Ai@gemulon.postgresql.org> (raw)

Revert changes to CONCURRENTLY that "sped up" Xmin advance

This reverts commit d9d076222f5b "VACUUM: ignore indexing operations
with CONCURRENTLY".

These changes caused indexes created with the CONCURRENTLY option to
miss heap tuples that were HOT-updated and HOT-pruned during the index
creation.  Before these changes, HOT pruning would have been prevented
by the Xmin of the transaction creating the index, but because this
change was precisely to allow the Xmin to move forward ignoring that
backend, now other backends scanning the table can prune them.  This is
not a problem for VACUUM (which requires a lock that conflicts with a
CREATE INDEX CONCURRENTLY operation), but HOT-prune can definitely
occur.  In other words, Xmin advancement was sped up, but at the cost of
corrupting the resulting index.

Regrettably, this means that the new feature in PG14 that RIC/CIC on
very large tables no longer force VACUUM to retain very old tuples goes
away.  We might try to implement it again in a later release, but for
now the risk of indexes missing tuples is too high and there's no easy
fix.

Backpatch to 14, where this change appeared.

Reported-by: Peter Slavov <pet.slavov@gmail.com>
Diagnosys-by: Andrey Borodin <x4mmm@yandex-team.ru>
Diagnosys-by: Michael Paquier <michael@paquier.xyz>
Diagnosys-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/17485-396609c6925b982d%40postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e28bb885196916b0a3d898ae4f2be0e38108d81b

Modified Files
--------------
doc/src/sgml/ref/create_index.sgml  |  2 --
doc/src/sgml/ref/reindex.sgml       |  2 --
src/backend/storage/ipc/procarray.c | 39 +++++++------------------------------
3 files changed, 7 insertions(+), 36 deletions(-)



view thread (2+ messages)

Message-ID: <E1nw7V2-0024eb-Ai@gemulon.postgresql.org>
Permalink:  ../E1nw7V2-0024eb-Ai@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nw7V2-0024eb-Ai@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Revert changes to CONCURRENTLY that "sped up" Xmin advance
  In-Reply-To: <E1nw7V2-0024eb-Ai@gemulon.postgresql.org>
  References: <E1nw7V2-0024eb-Ai@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox