pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't fail on libpq-generated error reports in ecpg_raise_backen
Date: Mon, 06 Jun 2022 15:21:19 +0000
Message-ID: <E1nyEXf-00305t-Cc@gemulon.postgresql.org> (raw)

Don't fail on libpq-generated error reports in ecpg_raise_backend().

An error PGresult generated by libpq itself, such as a report of
connection loss, won't have broken-down error fields.
ecpg_raise_backend() blithely assumed that PG_DIAG_MESSAGE_PRIMARY
would always be present, and would end up passing a NULL string
pointer to snprintf when it isn't.  That would typically crash
before 3779ac62d, and it would fail to provide a useful error report
in any case.  Best practice is to substitute PQerrorMessage(conn)
in such cases, so do that.

Per bug #17421 from Masayuki Hirose.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/17421-790ff887e3188874@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/16d68007cd7400061bd499b92eb80fbb9798362c

Modified Files
--------------
src/interfaces/ecpg/ecpglib/error.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)



view thread (8+ messages)  latest in thread

Message-ID: <E1nyEXf-00305t-Cc@gemulon.postgresql.org>
Permalink:  ../E1nyEXf-00305t-Cc@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nyEXf-00305t-Cc@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Don't fail on libpq-generated error reports in ecpg_raise_backen
  In-Reply-To: <E1nyEXf-00305t-Cc@gemulon.postgresql.org>
  References: <E1nyEXf-00305t-Cc@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox