From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't fail on libpq-generated error reports in pg_amcheck.
Date: Mon, 06 Jun 2022 15:27:07 +0000
Message-ID: <E1nyEdH-00308s-3k@gemulon.postgresql.org> (raw)
Don't fail on libpq-generated error reports in pg_amcheck.
An error PGresult generated by libpq itself, such as a report of
connection loss, won't have broken-down error fields.
should_processing_continue() blithely assumed that
PG_DIAG_SEVERITY_NONLOCALIZED would always be present, and would
dump core if it wasn't.
Per grepping to see if 6d157e7cb's mistake was repeated elsewhere.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/51da231597a9e414174cf621b219559e18269dc3
Modified Files
--------------
src/bin/pg_amcheck/pg_amcheck.c | 2 ++
1 file changed, 2 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Don't fail on libpq-generated error reports in pg_amcheck.
In-Reply-To: <E1nyEdH-00308s-3k@gemulon.postgresql.org>
References: <E1nyEdH-00308s-3k@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox