pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix portability issue in TAP tests of psql for locales
Date: Wed, 08 Jun 2022 02:26:59 +0000
Message-ID: <E1nylPP-003EWd-A2@gemulon.postgresql.org> (raw)

Fix portability issue in TAP tests of psql for locales

Some locales use a comma as decimal separator (like Czech or French),
and psql's 001_basic.pl for \timing was not able to handle that
properly.  This fixes the matching regexes to be able to handle both
comma and dot as possible decimal separators, as per a suggestion from
Andrew Dunstan.

psql tests were the only place with such a portability issue
(check-world passed here with a forced LANG/LANGUAGE).  These tests are
new as of c0280bc, so there is no need for a backpatch.

Reported-by: Pavel Stehule
Discussion: https://postgr.es/m/CAFj8pRBz8iQmd2aOaCLvO-rJY6vZr-h6Q0qvV0J+yb78J7uiaA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ca899d98b4aa50d80df9232c5c6ea9e4038cdf48

Modified Files
--------------
src/bin/psql/t/001_basic.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)



Message-ID: <E1nylPP-003EWd-A2@gemulon.postgresql.org>
Permalink:  ../E1nylPP-003EWd-A2@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1nylPP-003EWd-A2@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix portability issue in TAP tests of psql for locales
  In-Reply-To: <E1nylPP-003EWd-A2@gemulon.postgresql.org>
  References: <E1nylPP-003EWd-A2@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox