pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix busted tab completion of extension versions.
Date: Sat, 18 Jun 2022 23:46:32 +0000
Message-ID: <E1o2i9A-000iKp-OF@gemulon.postgresql.org> (raw)

Fix busted tab completion of extension versions.

In 02b8048ba I (tgl) got rid of the need for most tab-completion queries
to return pre-quoted identifiers.  But I over-hastily removed the
quote_ident call from Query_for_list_of_available_extension_versions*
too; those still need it, because what is returned isn't an identifier
at all and will (almost?) always need quoting.

Arguably we should use quote_literal here instead.  But quote_ident
works too and people may be used to that behavior, so stick with it.

In passing, fix inconsistent omission of schema-qualification in
Query_for_list_of_encodings.  That's not a security issue per our
current guidelines, but it ought to be like the rest.

Jeff Janes

Discussion: https://postgr.es/m/CAMkU=1yV+egSYrzWvbDY8VZ6bKEMrKbzxr-HTuiHi+wDgSUMgA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9cd43f6cbd8b6fbac6837bcdba5e12f0ecbafefb

Modified Files
--------------
src/bin/psql/tab-complete.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)



Message-ID: <E1o2i9A-000iKp-OF@gemulon.postgresql.org>
Permalink:  ../E1o2i9A-000iKp-OF@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o2i9A-000iKp-OF@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix busted tab completion of extension versions.
  In-Reply-To: <E1o2i9A-000iKp-OF@gemulon.postgresql.org>
  References: <E1o2i9A-000iKp-OF@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox