pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify tab completion of extension versions.
Date: Tue, 21 Jun 2022 16:04:20 +0000
Message-ID: <E1o3gMW-0018bA-Hg@gemulon.postgresql.org> (raw)

Simplify tab completion of extension versions.

Second thoughts about 9cd43f6cb: given that we're staying bug-compatible
with the old behavior of using double not single quotes for extension
versions, we can simplify this completion code by pretending that
extension versions *are* identifiers, and not using VERBATIM.  Then
_complete_from_query() will think that the query results are identifiers
in need of quoting, and we end up with the same behavior as before.

This doesn't work for Query_for_list_of_available_extension_versions_with_TO,
but let's just drop that: there is no other place where we handle
multi-keyword phrases that way, and it doesn't seem very desirable here
either.  Handle completion of "UPDATE TO" in our more usual pattern.

Discussion: https://postgr.es/m/CAMkU=1yV+egSYrzWvbDY8VZ6bKEMrKbzxr-HTuiHi+wDgSUMgA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/662dbe2c8657b01b436105754dff918a39a67365

Modified Files
--------------
src/bin/psql/tab-complete.c | 34 ++++++++++++----------------------
1 file changed, 12 insertions(+), 22 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1o3gMW-0018bA-Hg@gemulon.postgresql.org>
Permalink:  ../E1o3gMW-0018bA-Hg@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o3gMW-0018bA-Hg@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Simplify tab completion of extension versions.
  In-Reply-To: <E1o3gMW-0018bA-Hg@gemulon.postgresql.org>
  References: <E1o3gMW-0018bA-Hg@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox