pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: PL/Tcl: Don't link with -lc explicitly
Date: Thu, 23 Jun 2022 07:37:17 +0000
Message-ID: <E1o4HOv-001Oyi-5n@gemulon.postgresql.org> (raw)

PL/Tcl: Don't link with -lc explicitly

It has been reported that PL/Tcl built on macOS with GCC >=11 crashes.
The reason is that there is a hash_search() function in the operating
system's libraries, and that ends up being called instead of the one
in postgres.  This has something to do with how the linker resolves
references between the various possibilities it has been given, and
somehow something changed that it is now picking that one in this
configuration.

We found that removing the -lc from the link command line fixes this
problem.  The -lc was introduced a long time ago in commit
e3909672f12e0ddf3e202b824fda068ad2195ef2, and we think the reasons
might be obsolete, so we decided that we'll try to just remove it and
see if any problems arise.

Discussion: https://www.postgresql.org/message-id/flat/a78c847a-4f79-9286-be99-e819e9e4139e%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/41a2b56ae80bd13bc4cb09c48c6f873fd4382e05

Modified Files
--------------
src/pl/tcl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1o4HOv-001Oyi-5n@gemulon.postgresql.org>
Permalink:  ../E1o4HOv-001Oyi-5n@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o4HOv-001Oyi-5n@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: PL/Tcl: Don't link with -lc explicitly
  In-Reply-To: <E1o4HOv-001Oyi-5n@gemulon.postgresql.org>
  References: <E1o4HOv-001Oyi-5n@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox