pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: CREATE INDEX: use the original userid for more ACL checks. 6+ messages / 1 participants [nested] [flat]
* pgsql: CREATE INDEX: use the original userid for more ACL checks. @ 2022-06-25 16:10 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2022-06-25 16:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE INDEX: use the original userid for more ACL checks. Commit a117cebd638dd02e5c2e791c25e43745f233111b used the original userid for ACL checks located directly in DefineIndex(), but it still adopted the table owner userid for more ACL checks than intended. That broke dump/reload of indexes that refer to an operator class, collation, or exclusion operator in a schema other than "public" or "pg_catalog". Back-patch to v10 (all supported versions), like the earlier commit. Nathan Bossart and Noah Misch Discussion: https://postgr.es/m/f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/88b39e61486a8925a3861d50c306a51eaa1af8d6 Modified Files -------------- contrib/citext/Makefile | 2 +- contrib/citext/expected/create_index_acl.out | 81 ++++++++++++++++++++++++ contrib/citext/sql/create_index_acl.sql | 82 +++++++++++++++++++++++++ src/backend/commands/indexcmds.c | 92 ++++++++++++++++++++++++---- 4 files changed, 244 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: CREATE INDEX: use the original userid for more ACL checks. @ 2022-06-25 16:10 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2022-06-25 16:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE INDEX: use the original userid for more ACL checks. Commit a117cebd638dd02e5c2e791c25e43745f233111b used the original userid for ACL checks located directly in DefineIndex(), but it still adopted the table owner userid for more ACL checks than intended. That broke dump/reload of indexes that refer to an operator class, collation, or exclusion operator in a schema other than "public" or "pg_catalog". Back-patch to v10 (all supported versions), like the earlier commit. Nathan Bossart and Noah Misch Discussion: https://postgr.es/m/f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/00377b9a02b89a831ae50e1c718d34565356698f Modified Files -------------- contrib/citext/Makefile | 2 +- contrib/citext/expected/create_index_acl.out | 86 +++++++++++++++++++++++++ contrib/citext/sql/create_index_acl.sql | 88 +++++++++++++++++++++++++ src/backend/commands/indexcmds.c | 96 +++++++++++++++++++++++----- 4 files changed, 256 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: CREATE INDEX: use the original userid for more ACL checks. @ 2022-06-25 16:10 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2022-06-25 16:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE INDEX: use the original userid for more ACL checks. Commit a117cebd638dd02e5c2e791c25e43745f233111b used the original userid for ACL checks located directly in DefineIndex(), but it still adopted the table owner userid for more ACL checks than intended. That broke dump/reload of indexes that refer to an operator class, collation, or exclusion operator in a schema other than "public" or "pg_catalog". Back-patch to v10 (all supported versions), like the earlier commit. Nathan Bossart and Noah Misch Discussion: https://postgr.es/m/f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ace9973867c2f17ed6191a4a3b9a46939a2df45b Modified Files -------------- contrib/citext/Makefile | 2 +- contrib/citext/expected/create_index_acl.out | 78 ++++++++++++++++++++++ contrib/citext/sql/create_index_acl.sql | 79 +++++++++++++++++++++++ src/backend/commands/indexcmds.c | 96 +++++++++++++++++++++++----- 4 files changed, 239 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: CREATE INDEX: use the original userid for more ACL checks. @ 2022-06-25 16:10 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2022-06-25 16:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE INDEX: use the original userid for more ACL checks. Commit a117cebd638dd02e5c2e791c25e43745f233111b used the original userid for ACL checks located directly in DefineIndex(), but it still adopted the table owner userid for more ACL checks than intended. That broke dump/reload of indexes that refer to an operator class, collation, or exclusion operator in a schema other than "public" or "pg_catalog". Back-patch to v10 (all supported versions), like the earlier commit. Nathan Bossart and Noah Misch Discussion: https://postgr.es/m/f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6d49cc28613b81c96f1c0e8891515e8f0aeafb61 Modified Files -------------- contrib/citext/Makefile | 2 +- contrib/citext/expected/create_index_acl.out | 81 ++++++++++++++++++++++++ contrib/citext/sql/create_index_acl.sql | 82 ++++++++++++++++++++++++ src/backend/commands/indexcmds.c | 94 ++++++++++++++++++++++++---- 4 files changed, 245 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: CREATE INDEX: use the original userid for more ACL checks. @ 2022-06-25 16:10 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2022-06-25 16:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE INDEX: use the original userid for more ACL checks. Commit a117cebd638dd02e5c2e791c25e43745f233111b used the original userid for ACL checks located directly in DefineIndex(), but it still adopted the table owner userid for more ACL checks than intended. That broke dump/reload of indexes that refer to an operator class, collation, or exclusion operator in a schema other than "public" or "pg_catalog". Back-patch to v10 (all supported versions), like the earlier commit. Nathan Bossart and Noah Misch Discussion: https://postgr.es/m/f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/93731d549e15deb98cfab49f3d879beb1986daca Modified Files -------------- contrib/citext/Makefile | 2 +- contrib/citext/expected/create_index_acl.out | 78 ++++++++++++++++++++++ contrib/citext/sql/create_index_acl.sql | 79 +++++++++++++++++++++++ src/backend/commands/indexcmds.c | 96 +++++++++++++++++++++++----- 4 files changed, 239 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: CREATE INDEX: use the original userid for more ACL checks. @ 2022-06-25 16:10 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2022-06-25 16:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE INDEX: use the original userid for more ACL checks. Commit a117cebd638dd02e5c2e791c25e43745f233111b used the original userid for ACL checks located directly in DefineIndex(), but it still adopted the table owner userid for more ACL checks than intended. That broke dump/reload of indexes that refer to an operator class, collation, or exclusion operator in a schema other than "public" or "pg_catalog". Back-patch to v10 (all supported versions), like the earlier commit. Nathan Bossart and Noah Misch Discussion: https://postgr.es/m/f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8782ce49e4d0c8886cd09d824dd55f741f709f8f Modified Files -------------- contrib/citext/Makefile | 2 +- contrib/citext/expected/create_index_acl.out | 78 ++++++++++++++++++++++ contrib/citext/sql/create_index_acl.sql | 79 +++++++++++++++++++++++ src/backend/commands/indexcmds.c | 96 +++++++++++++++++++++++----- 4 files changed, 239 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-06-25 16:10 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-06-25 16:10 pgsql: CREATE INDEX: use the original userid for more ACL checks. Noah Misch <noah@leadboat.com> 2022-06-25 16:10 pgsql: CREATE INDEX: use the original userid for more ACL checks. Noah Misch <noah@leadboat.com> 2022-06-25 16:10 pgsql: CREATE INDEX: use the original userid for more ACL checks. Noah Misch <noah@leadboat.com> 2022-06-25 16:10 pgsql: CREATE INDEX: use the original userid for more ACL checks. Noah Misch <noah@leadboat.com> 2022-06-25 16:10 pgsql: CREATE INDEX: use the original userid for more ACL checks. Noah Misch <noah@leadboat.com> 2022-06-25 16:10 pgsql: CREATE INDEX: use the original userid for more ACL checks. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox