From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: CREATE INDEX: use the original userid for more ACL checks.
Date: Sat, 25 Jun 2022 16:10:22 +0000
Message-ID: <E1o58MY-001lnV-CD@gemulon.postgresql.org> (raw)
CREATE INDEX: use the original userid for more ACL checks.
Commit a117cebd638dd02e5c2e791c25e43745f233111b used the original userid
for ACL checks located directly in DefineIndex(), but it still adopted
the table owner userid for more ACL checks than intended. That broke
dump/reload of indexes that refer to an operator class, collation, or
exclusion operator in a schema other than "public" or "pg_catalog".
Back-patch to v10 (all supported versions), like the earlier commit.
Nathan Bossart and Noah Misch
Discussion: https://postgr.es/m/f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/6d49cc28613b81c96f1c0e8891515e8f0aeafb61
Modified Files
--------------
contrib/citext/Makefile | 2 +-
contrib/citext/expected/create_index_acl.out | 81 ++++++++++++++++++++++++
contrib/citext/sql/create_index_acl.sql | 82 ++++++++++++++++++++++++
src/backend/commands/indexcmds.c | 94 ++++++++++++++++++++++++----
4 files changed, 245 insertions(+), 14 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com
Subject: Re: pgsql: CREATE INDEX: use the original userid for more ACL checks.
In-Reply-To: <E1o58MY-001lnV-CD@gemulon.postgresql.org>
References: <E1o58MY-001lnV-CD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox