pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Harden range_table_mutator() against null RangeTblEntry.subquery
Date: Sun, 26 Jun 2022 12:58:28 +0000
Message-ID: <E1o5RqO-001uCT-JP@gemulon.postgresql.org> (raw)

Harden range_table_mutator() against null RangeTblEntry.subquery.

Commit 64919aaab made pull_up_simple_subquery set rte->subquery = NULL
after doing the deed, so that we don't waste cycles copying a
now-useless subquery tree around.  This turns out to create a core dump
hazard in range_table_mutator, which supposes that that field is never
NULL.  Apparently none of our own code invokes query_tree_mutator or
range_table_mutator on the top Query after subquery pullup; but it
wouldn't be surprising if outside code does, and anyway I'm working
on a v16 patch that will need it.

We can fix this cleanly by just getting rid of the special-case
handling of this field and treating it more like all the rest.
I think the special case might be left over from a time when
QTW_DONT_COPY_QUERY was the default behavior, but that was eons ago.

Thanks to Dean Rasheed for review.

Discussion: https://postgr.es/m/545569.1656107045@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ebc584ed495d7ad3a3f33db4e75d9543ff6a87d1

Modified Files
--------------
src/backend/nodes/nodeFuncs.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)



Message-ID: <E1o5RqO-001uCT-JP@gemulon.postgresql.org>
Permalink:  ../E1o5RqO-001uCT-JP@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o5RqO-001uCT-JP@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Harden range_table_mutator() against null RangeTblEntry.subquery
  In-Reply-To: <E1o5RqO-001uCT-JP@gemulon.postgresql.org>
  References: <E1o5RqO-001uCT-JP@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox