pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages.
Date: Tue, 05 Jul 2022 17:06:41 +0000
Message-ID: <E1o8m0V-001LYQ-HT@gemulon.postgresql.org> (raw)

Fix pg_upgrade to detect non-upgradable anyarray usages.

When we changed some built-in functions to use anycompatiblearray
instead of anyarray, we created a dump/restore hazard for user-defined
operators and aggregates relying on those functions: the user objects
have to be modified to change their signatures similarly.  This causes
pg_upgrade to fail partway through if the source installation contains
such objects.  We generally try to have pg_upgrade detect such hazards
and fail before it does anything exciting, so add logic to detect
this case too.

Back-patch to v14 where the change was made.

Justin Pryzby, reviewed by Andrey Borodin

Discussion: https://postgr.es/m/3383880.QJadu78ljV@vejsadalnx

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/175e60a5e35e213f42ed69eeb5ab992a49ae41f4

Modified Files
--------------
src/bin/pg_upgrade/check.c | 134 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 134 insertions(+)



view thread (3+ messages)

Message-ID: <E1o8m0V-001LYQ-HT@gemulon.postgresql.org>
Permalink:  ../E1o8m0V-001LYQ-HT@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o8m0V-001LYQ-HT@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages.
  In-Reply-To: <E1o8m0V-001LYQ-HT@gemulon.postgresql.org>
  References: <E1o8m0V-001LYQ-HT@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox