pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages.
3+ messages / 1 participants
[nested] [flat]

* pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages.
@ 2022-07-05 17:06 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-07-05 17:06 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix pg_upgrade to detect non-upgradable anyarray usages.

When we changed some built-in functions to use anycompatiblearray
instead of anyarray, we created a dump/restore hazard for user-defined
operators and aggregates relying on those functions: the user objects
have to be modified to change their signatures similarly.  This causes
pg_upgrade to fail partway through if the source installation contains
such objects.  We generally try to have pg_upgrade detect such hazards
and fail before it does anything exciting, so add logic to detect
this case too.

Back-patch to v14 where the change was made.

Justin Pryzby, reviewed by Andrey Borodin

Discussion: https://postgr.es/m/3383880.QJadu78ljV@vejsadalnx

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/09878cdd489ff7aca761998e7cb104f4fd98ae02

Modified Files
--------------
src/bin/pg_upgrade/check.c | 135 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 135 insertions(+)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages.
@ 2022-07-05 17:06 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-07-05 17:06 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix pg_upgrade to detect non-upgradable anyarray usages.

When we changed some built-in functions to use anycompatiblearray
instead of anyarray, we created a dump/restore hazard for user-defined
operators and aggregates relying on those functions: the user objects
have to be modified to change their signatures similarly.  This causes
pg_upgrade to fail partway through if the source installation contains
such objects.  We generally try to have pg_upgrade detect such hazards
and fail before it does anything exciting, so add logic to detect
this case too.

Back-patch to v14 where the change was made.

Justin Pryzby, reviewed by Andrey Borodin

Discussion: https://postgr.es/m/3383880.QJadu78ljV@vejsadalnx

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c069f427855a486a4d32d84e2bf4c932df00d7d5

Modified Files
--------------
src/bin/pg_upgrade/check.c | 135 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 135 insertions(+)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages.
@ 2022-07-05 17:06 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-07-05 17:06 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix pg_upgrade to detect non-upgradable anyarray usages.

When we changed some built-in functions to use anycompatiblearray
instead of anyarray, we created a dump/restore hazard for user-defined
operators and aggregates relying on those functions: the user objects
have to be modified to change their signatures similarly.  This causes
pg_upgrade to fail partway through if the source installation contains
such objects.  We generally try to have pg_upgrade detect such hazards
and fail before it does anything exciting, so add logic to detect
this case too.

Back-patch to v14 where the change was made.

Justin Pryzby, reviewed by Andrey Borodin

Discussion: https://postgr.es/m/3383880.QJadu78ljV@vejsadalnx

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/175e60a5e35e213f42ed69eeb5ab992a49ae41f4

Modified Files
--------------
src/bin/pg_upgrade/check.c | 134 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 134 insertions(+)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-07-05 17:06 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 17:06 pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages. Tom Lane <tgl@sss.pgh.pa.us>
2022-07-05 17:06 pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages. Tom Lane <tgl@sss.pgh.pa.us>
2022-07-05 17:06 pgsql: Fix pg_upgrade to detect non-upgradable anyarray usages. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox