pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Revert 019_replslot_limit.pl related debugging aids. 2+ messages / 1 participants [nested] [flat]
* pgsql: Revert 019_replslot_limit.pl related debugging aids. @ 2022-07-05 18:17 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 2+ messages in thread From: Andres Freund @ 2022-07-05 18:17 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert 019_replslot_limit.pl related debugging aids. This reverts most of 91c0570a791, f28bf667f60, fe0972ee5e6, afdeff10526. The only thing left is the retry loop in 019_replslot_limit.pl that avoids spurious failures by retrying a couple times. We haven't seen any hard evidence that this is caused by anything but slow process shutdown. We did not find any cases where walsenders did not vanish after waiting for longer. Therefore there's no reason for this debugging code to remain. Discussion: https://postgr.es/m/20220530190155.47wr3x2prdwyciah@alap3.anarazel.de Backpatch: 15- Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/49ddd98763624cfb6020f8b525a021e9788473a5 Modified Files -------------- src/backend/replication/slot.c | 43 ------------------------------- src/backend/storage/lmgr/lwlock.c | 7 ----- src/backend/utils/init/postinit.c | 18 ------------- src/bin/pg_basebackup/pg_basebackup.c | 10 +------ src/include/storage/lwlock.h | 1 - src/test/recovery/t/019_replslot_limit.pl | 13 +++------- 6 files changed, 5 insertions(+), 87 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revert 019_replslot_limit.pl related debugging aids. @ 2022-07-05 18:17 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 2+ messages in thread From: Andres Freund @ 2022-07-05 18:17 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert 019_replslot_limit.pl related debugging aids. This reverts most of 91c0570a791, f28bf667f60, fe0972ee5e6, afdeff10526. The only thing left is the retry loop in 019_replslot_limit.pl that avoids spurious failures by retrying a couple times. We haven't seen any hard evidence that this is caused by anything but slow process shutdown. We did not find any cases where walsenders did not vanish after waiting for longer. Therefore there's no reason for this debugging code to remain. Discussion: https://postgr.es/m/20220530190155.47wr3x2prdwyciah@alap3.anarazel.de Backpatch: 15- Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3f8148c256e067dc2e8929ed174671ba7dc3339c Modified Files -------------- src/backend/replication/slot.c | 43 ------------------------------- src/backend/storage/lmgr/lwlock.c | 7 ----- src/backend/utils/init/postinit.c | 18 ------------- src/bin/pg_basebackup/pg_basebackup.c | 10 +------ src/include/storage/lwlock.h | 1 - src/test/recovery/t/019_replslot_limit.pl | 13 +++------- 6 files changed, 5 insertions(+), 87 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-07-05 18:17 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-05 18:17 pgsql: Revert 019_replslot_limit.pl related debugging aids. Andres Freund <andres@anarazel.de> 2022-07-05 18:17 pgsql: Revert 019_replslot_limit.pl related debugging aids. Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox