pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert 019_replslot_limit.pl related debugging aids.
Date: Tue, 05 Jul 2022 18:17:33 +0000
Message-ID: <E1o8n75-001MAE-NY@gemulon.postgresql.org> (raw)

Revert 019_replslot_limit.pl related debugging aids.

This reverts most of 91c0570a791, f28bf667f60, fe0972ee5e6, afdeff10526. The
only thing left is the retry loop in 019_replslot_limit.pl that avoids
spurious failures by retrying a couple times.

We haven't seen any hard evidence that this is caused by anything but slow
process shutdown. We did not find any cases where walsenders did not vanish
after waiting for longer. Therefore there's no reason for this debugging code
to remain.

Discussion: https://postgr.es/m/20220530190155.47wr3x2prdwyciah@alap3.anarazel.de
Backpatch: 15-

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3f8148c256e067dc2e8929ed174671ba7dc3339c

Modified Files
--------------
src/backend/replication/slot.c            | 43 -------------------------------
src/backend/storage/lmgr/lwlock.c         |  7 -----
src/backend/utils/init/postinit.c         | 18 -------------
src/bin/pg_basebackup/pg_basebackup.c     | 10 +------
src/include/storage/lwlock.h              |  1 -
src/test/recovery/t/019_replslot_limit.pl | 13 +++-------
6 files changed, 5 insertions(+), 87 deletions(-)



view thread (2+ messages)

Message-ID: <E1o8n75-001MAE-NY@gemulon.postgresql.org>
Permalink:  ../E1o8n75-001MAE-NY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o8n75-001MAE-NY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Revert 019_replslot_limit.pl related debugging aids.
  In-Reply-To: <E1o8n75-001MAE-NY@gemulon.postgresql.org>
  References: <E1o8n75-001MAE-NY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox