pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz
Date: Tue, 05 Jul 2022 18:33:25 +0000
Message-ID: <E1o8nMR-001MJu-L6@gemulon.postgresql.org> (raw)

expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR size.

The new expression step types increased the size of ExprEvalStep by ~4 for all
types of expression steps, slowing down expression evaluation noticeably. Move
them out of line.

There's other issues with these expression steps, but addressing them is
largely independent of this aspect.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20220616233130.rparivafipt6doj3@alap3.anarazel.de
Backpatch: 15-

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5a1ab894f758fae95b8d40fff0b0fa5048b09467

Modified Files
--------------
src/backend/executor/execExpr.c       |  93 +++++++++++++++-------------
src/backend/executor/execExprInterp.c | 104 ++++++++++++++++---------------
src/include/executor/execExpr.h       | 111 +++++++++++++++++++---------------
src/tools/pgindent/typedefs.list      |   2 +
4 files changed, 170 insertions(+), 140 deletions(-)



view thread (2+ messages)

Message-ID: <E1o8nMR-001MJu-L6@gemulon.postgresql.org>
Permalink:  ../E1o8nMR-001MJu-L6@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o8nMR-001MJu-L6@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz
  In-Reply-To: <E1o8nMR-001MJu-L6@gemulon.postgresql.org>
  References: <E1o8nMR-001MJu-L6@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox