pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz
2+ messages / 1 participants
[nested] [flat]

* pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz
@ 2022-07-05 18:33 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2022-07-05 18:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR size.

The new expression step types increased the size of ExprEvalStep by ~4 for all
types of expression steps, slowing down expression evaluation noticeably. Move
them out of line.

There's other issues with these expression steps, but addressing them is
largely independent of this aspect.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20220616233130.rparivafipt6doj3@alap3.anarazel.de
Backpatch: 15-

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/67b26703b4152a30a91208e28a4b72b3abda5832

Modified Files
--------------
src/backend/executor/execExpr.c       |  93 +++++++++++++++-------------
src/backend/executor/execExprInterp.c | 104 ++++++++++++++++---------------
src/include/executor/execExpr.h       | 111 +++++++++++++++++++---------------
src/tools/pgindent/typedefs.list      |   2 +
4 files changed, 170 insertions(+), 140 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz
@ 2022-07-05 18:33 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2022-07-05 18:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR size.

The new expression step types increased the size of ExprEvalStep by ~4 for all
types of expression steps, slowing down expression evaluation noticeably. Move
them out of line.

There's other issues with these expression steps, but addressing them is
largely independent of this aspect.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20220616233130.rparivafipt6doj3@alap3.anarazel.de
Backpatch: 15-

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5a1ab894f758fae95b8d40fff0b0fa5048b09467

Modified Files
--------------
src/backend/executor/execExpr.c       |  93 +++++++++++++++-------------
src/backend/executor/execExprInterp.c | 104 ++++++++++++++++---------------
src/include/executor/execExpr.h       | 111 +++++++++++++++++++---------------
src/tools/pgindent/typedefs.list      |   2 +
4 files changed, 170 insertions(+), 140 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-07-05 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 18:33 pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz Andres Freund <andres@anarazel.de>
2022-07-05 18:33 pgsql: expression eval: Fix EEOP_JSON_CONSTRUCTOR and EEOP_JSONEXPR siz Andres Freund <andres@anarazel.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox