From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor sending of DataRow messages in replication protocol
Date: Wed, 06 Jul 2022 06:48:58 +0000
Message-ID: <E1o8yqG-001RPJ-Ul@gemulon.postgresql.org> (raw)
Refactor sending of DataRow messages in replication protocol
Some routines open-coded the construction of DataRow messages. Use
TupOutputState struct and associated functions instead, which was
already done in some places.
SendTimeLineHistory() is a bit more complicated and isn't converted by
this.
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/7e4fdbdc-699c-4cd0-115d-fb78a957fc22@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/16d52fc89dbe8394ed318521e076f08fd2e4bf8c
Modified Files
--------------
src/backend/access/common/printsimple.c | 11 +++++
src/backend/replication/basebackup_copy.c | 69 ++++++++++---------------------
2 files changed, 33 insertions(+), 47 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org
Subject: Re: pgsql: Refactor sending of DataRow messages in replication protocol
In-Reply-To: <E1o8yqG-001RPJ-Ul@gemulon.postgresql.org>
References: <E1o8yqG-001RPJ-Ul@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox