From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstat: drop subscription stats without slot as well, fix commen
Date: Wed, 06 Jul 2022 16:28:07 +0000
Message-ID: <E1o97sj-001VPA-P8@gemulon.postgresql.org> (raw)
pgstat: drop subscription stats without slot as well, fix comment
There's no reason anymore to only drop subscription stats if associated with a
slot, now that stats drops are transactional. And since there's now no other
cleanup of stats, this would lead to stats for slot-less subscriptions to get
leaked (however most slot-less subs won't have stats).
Additionally, the comment referring to autovacuum cleaning up stats was
clearly outdated.
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAD21AoAwiby3HeJE7vJe16Gr75RFfJ640dyHqvsiUhyKJTXPtw@mail.gmail.com
Backpatch: 15-
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7b64e4b3fa04769b725306a75bf3dd26e5a854fa
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de
Subject: Re: pgsql: pgstat: drop subscription stats without slot as well, fix commen
In-Reply-To: <E1o97sj-001VPA-P8@gemulon.postgresql.org>
References: <E1o97sj-001VPA-P8@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox