From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_stat_statements: Fix test that assumes wal_records = rows.
Date: Wed, 06 Jul 2022 17:10:47 +0000
Message-ID: <E1o98Y1-001VgP-Kq@gemulon.postgresql.org> (raw)
pg_stat_statements: Fix test that assumes wal_records = rows.
It's not very robust to assume that each inserted row will produce
exactly one WAL record and that no other WAL records will be generated
in the process, because for example a particular transaction could
always be the one that has to extend clog.
Because these tests are not run by 'make installcheck' but only by
'make check', it may be that in our current testing infrastructure
this can't be hit, but it doesn't seem like a good idea to rely on
that, since unrelated changes to the regression tests or the way
write-ahead logging is done could easily cause it to start happening,
and debugging such failures is a pain.
Adjust the regression test to be less sensitive.
Anton Melnikov, reviewed by Julien Rouhaud
Discussion: http://postgr.es/m/1ccd00d9-1723-6b68-ae56-655aab00d406@inbox.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2d7ead85267cc0a41ea4e94ee0ac144d5214d353
Modified Files
--------------
contrib/pg_stat_statements/expected/pg_stat_statements.out | 8 ++++----
contrib/pg_stat_statements/sql/pg_stat_statements.sql | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org
Subject: Re: pgsql: pg_stat_statements: Fix test that assumes wal_records = rows.
In-Reply-To: <E1o98Y1-001VgP-Kq@gemulon.postgresql.org>
References: <E1o98Y1-001VgP-Kq@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox