pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make Windows 10 the minimal runtime requirement for WIN32
Date: Thu, 07 Jul 2022 04:26:36 +0000
Message-ID: <E1o9J62-001aJP-P3@gemulon.postgresql.org> (raw)

Make Windows 10 the minimal runtime requirement for WIN32

This commit bumps the runtime value of _WIN32_WINNT to be 0x0A00 for any
builds on Windows.  Hence, this makes Windows 10 the minimal requirement
when running PostgreSQL under WIN32, be it for builds of Cygwin, MinGW
or Visual Studio.

The previous minimal runtime version was either Windows Vista when
building with at least Visual Studio 2015 or Windows XP for the rest.

Windows 10 is the most modern version supported by Microsoft, and per
discussion, as we don't have buildfarm members that run older versions
anymore, this is the minimal supported version that suits better for our
needs.  This will actually make easier the development of some patches,
two being async I/O and large page handling by avoiding a lot of
compatibility gotchas, on platforms that have most likely few users
anyway.

It is possible to remove MIN_WINNT in win32.h and the macros
IsWindowsXXXOrGreater() that were used in the code at runtime to check
which version of Windows was getting used.  The change in pg_locale.c
comes from Juan.  Note that all my tests passed, and that the CI is
green.  The buildfarm will quickly tell if this needs more adjustments.

Author: Michael Paquier, Juan José Santamaría Flecha
Reviewed-by: Thomas Munro
Discussion: https://postgr.es/m/Yo7tHKD8VCkeNi71@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/495ed0ef2d72a6a74def296e042022479d5d07bd

Modified Files
--------------
doc/src/sgml/install-windows.sgml |  9 ++-------
doc/src/sgml/installation.sgml    |  9 ++++-----
src/backend/main/main.c           | 17 -----------------
src/backend/utils/adt/pg_locale.c |  4 ++--
src/bin/pg_ctl/pg_ctl.c           | 26 ++------------------------
src/include/port/win32.h          | 17 +++--------------
6 files changed, 13 insertions(+), 69 deletions(-)



Message-ID: <E1o9J62-001aJP-P3@gemulon.postgresql.org>
Permalink:  ../E1o9J62-001aJP-P3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o9J62-001aJP-P3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Make Windows 10 the minimal runtime requirement for WIN32
  In-Reply-To: <E1o9J62-001aJP-P3@gemulon.postgresql.org>
  References: <E1o9J62-001aJP-P3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox