pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Convert macros to static inline functions (block.h)
Date: Thu, 07 Jul 2022 06:51:19 +0000
Message-ID: <E1o9LM6-001bKO-7v@gemulon.postgresql.org> (raw)

Convert macros to static inline functions (block.h)

Remove BlockIdIsValid(), which wasn't used and is unnecessary.

Remove BlockIdCopy(), which wasn't used and can be done by struct
assignment.

(BlockIdEquals() also isn't used, but seems reasonable to keep
around.)

Reviewed-by: Amul Sul <sulamul@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/5b558da8-99fb-0a99-83dd-f72f05388517%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d63d957e330c611f7a8c0ed02e4407f40f975026

Modified Files
--------------
src/include/storage/block.h | 53 ++++++++++++++++++++-------------------------
1 file changed, 23 insertions(+), 30 deletions(-)



view thread (10+ messages)  latest in thread

Message-ID: <E1o9LM6-001bKO-7v@gemulon.postgresql.org>
Permalink:  ../E1o9LM6-001bKO-7v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o9LM6-001bKO-7v@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Convert macros to static inline functions (block.h)
  In-Reply-To: <E1o9LM6-001bKO-7v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox