pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix alias matching in transformLockingClause().
Date: Thu, 07 Jul 2022 12:14:18 +0000
Message-ID: <E1o9QOe-001dVe-Ja@gemulon.postgresql.org> (raw)

Fix alias matching in transformLockingClause().

When locking a specific named relation for a FOR [KEY] UPDATE/SHARE
clause, transformLockingClause() finds the relation to lock by
scanning the rangetable for an RTE with a matching eref->aliasname.
However, it failed to account for the visibility rules of a join RTE.

If a join RTE doesn't have a user-supplied alias, it will have a
generated eref->aliasname of "unnamed_join" that is not visible as a
relation name in the parse namespace. Such an RTE needs to be skipped,
otherwise it might be found in preference to a regular base relation
with a user-supplied alias of "unnamed_join", preventing it from being
locked.

In addition, if a join RTE doesn't have a user-supplied alias, but
does have a join_using_alias, then the RTE needs to be matched using
that alias rather than the generated eref->aliasname, otherwise a
misleading "relation not found" error will be reported rather than a
"join cannot be locked" error.

Backpatch all the way, except for the second part which only goes back
to 14, where JOIN USING aliases were added.

Dean Rasheed, reviewed by Tom Lane.

Discussion: https://postgr.es/m/CAEZATCUY_KOBnqxbTSPf=7fz9HWPnZ5Xgb9SwYzZ8rFXe7nb=w@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e88b1f1e2289e2301a5c4f85c659656ae6291403

Modified Files
--------------
src/backend/parser/analyze.c       | 9 +++++++++
src/test/regress/expected/join.out | 8 ++++++++
src/test/regress/sql/join.sql      | 6 ++++++
3 files changed, 23 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1o9QOe-001dVe-Ja@gemulon.postgresql.org>
Permalink:  ../E1o9QOe-001dVe-Ja@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o9QOe-001dVe-Ja@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dean.a.rasheed@gmail.com
  Subject: Re: pgsql: Fix alias matching in transformLockingClause().
  In-Reply-To: <E1o9QOe-001dVe-Ja@gemulon.postgresql.org>
  References: <E1o9QOe-001dVe-Ja@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox