pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove stray references to lefttree/righttree in the executor.
Date: Thu, 07 Jul 2022 15:24:04 +0000
Message-ID: <E1o9TMI-001ent-TD@gemulon.postgresql.org> (raw)

Remove stray references to lefttree/righttree in the executor.

The general convention in the executor is to refer to child plans
and planstates via the outerPlan[State] and innerPlan[State]
macros, but a few places didn't do it like that.  For consistency
and readability, convert all the stragglers to use the macros.
(See also commit 40f42d2a3, which did some similar cleanup a few
years ago, but missed these cases.)

Richard Guo

Discussion: https://postgr.es/m/CAMbWs4-vYhh1xsa_veah4PUed2Xq=Ed_YH3=Mqt5A3Y=EgfCEg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/88210542106de5b26fe6aa088d1811b68502d224

Modified Files
--------------
src/backend/executor/execAmi.c         | 10 +++++-----
src/backend/executor/execCurrent.c     |  2 +-
src/backend/executor/nodeAgg.c         |  2 +-
src/backend/executor/nodeGather.c      |  4 ++--
src/backend/executor/nodeGatherMerge.c |  4 ++--
src/backend/executor/nodeHash.c        |  6 ++++--
src/backend/executor/nodeHashjoin.c    | 15 +++++++++------
src/backend/executor/nodeLimit.c       |  6 ++++--
src/backend/executor/nodeLockRows.c    |  6 ++++--
src/backend/executor/nodeMergejoin.c   | 11 +++++++----
src/backend/executor/nodeProjectSet.c  |  6 ++++--
src/backend/executor/nodeResult.c      |  7 ++++---
src/backend/executor/nodeSetOp.c       |  8 +++++---
src/backend/executor/nodeUnique.c      |  6 ++++--
14 files changed, 56 insertions(+), 37 deletions(-)



Message-ID: <E1o9TMI-001ent-TD@gemulon.postgresql.org>
Permalink:  ../E1o9TMI-001ent-TD@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o9TMI-001ent-TD@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Remove stray references to lefttree/righttree in the executor.
  In-Reply-To: <E1o9TMI-001ent-TD@gemulon.postgresql.org>
  References: <E1o9TMI-001ent-TD@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox