pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve two comments related to a boolean DefElem's value
Date: Mon, 11 Jul 2022 02:07:51 +0000
Message-ID: <E1oAipx-002CRK-Kr@gemulon.postgresql.org> (raw)

Improve two comments related to a boolean DefElem's value

The original comments mentioned a "parameter" as something not defined
in a fast-exit path to assume a true status.  This is rather confusing
as the parameter DefElem is defined, and the intention is to check if
its value is defined.  This improves both comments to mention the value
assigned to the DefElem's value instead, so as future patches are able
to catch the tweak if this code pattern gets copied around more.

Author: Peter Smith
Discussion: https://postgr.es/m/CAHut+Pv0yWynWTmp4o34s0d98xVubys9fy=p0YXsZ5_sUcNnMw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8445f5a21d40b969673ca03918c74b4fbc882bf4

Modified Files
--------------
src/backend/commands/copy.c   | 2 +-
src/backend/commands/define.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1oAipx-002CRK-Kr@gemulon.postgresql.org>
Permalink:  ../E1oAipx-002CRK-Kr@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oAipx-002CRK-Kr@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Improve two comments related to a boolean DefElem's value
  In-Reply-To: <E1oAipx-002CRK-Kr@gemulon.postgresql.org>
  References: <E1oAipx-002CRK-Kr@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox