From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve error reporting from validate_exec().
Date: Tue, 12 Jul 2022 19:37:51 +0000
Message-ID: <E1oBLhe-002Tmx-63@gemulon.postgresql.org> (raw)
Improve error reporting from validate_exec().
validate_exec() didn't guarantee to set errno to something appropriate
after a failure, leading to callers not being able to print an on-point
message. Improve that.
Noted by Kyotaro Horiguchi, though this isn't exactly his proposal.
Discussion: https://postgr.es/m/20220615.131403.1791191615590453058.horikyota.ntt@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/920072339f304a7da0b5de966117420c96ad78cb
Modified Files
--------------
src/bin/pg_upgrade/exec.c | 11 ++---------
src/common/exec.c | 16 ++++++++++++++--
2 files changed, 16 insertions(+), 11 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Improve error reporting from validate_exec().
In-Reply-To: <E1oBLhe-002Tmx-63@gemulon.postgresql.org>
References: <E1oBLhe-002Tmx-63@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox