pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tidy up code in get_cheapest_group_keys_order()
Date: Wed, 13 Jul 2022 02:03:15 +0000
Message-ID: <E1oBRib-002WP8-L6@gemulon.postgresql.org> (raw)

Tidy up code in get_cheapest_group_keys_order()

There are a few things that we could do a little better within
get_cheapest_group_keys_order():

1. We should be using list_free() rather than pfree() on a List.

2. We should use for_each_from() instead of manually coding a for loop to
skip the first n elements of a List

3. list_truncate(list_copy(...), n) is not a great way to copy the first n
elements of a list. Let's invent list_copy_head() for that.  That way we
don't need to copy the entire list just to truncate it directly
afterwards.

4. We can simplify finding the cheapest cost by setting the cheapest cost
variable to DBL_MAX.  That allows us to skip special-casing the initial
iteration of the loop.

Author: David Rowley
Discussion: https://postgr.es/m/CAApHDvrGyL3ft8waEkncG9y5HDMu5TFFJB1paoTC8zi9YK97Nw@mail.gmail.com
Backpatch-through: 15, where get_cheapest_group_keys_order was added.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4cc832f94a583146fcf7886c9ce685894956d804

Modified Files
--------------
src/backend/nodes/list.c              | 21 +++++++++++++++++++++
src/backend/optimizer/path/pathkeys.c | 34 ++++++++++++++++++----------------
src/include/nodes/pg_list.h           |  1 +
3 files changed, 40 insertions(+), 16 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oBRib-002WP8-L6@gemulon.postgresql.org>
Permalink:  ../E1oBRib-002WP8-L6@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oBRib-002WP8-L6@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Tidy up code in get_cheapest_group_keys_order()
  In-Reply-To: <E1oBRib-002WP8-L6@gemulon.postgresql.org>
  References: <E1oBRib-002WP8-L6@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox