pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Tidy up code in get_cheapest_group_keys_order() 2+ messages / 1 participants [nested] [flat]
* pgsql: Tidy up code in get_cheapest_group_keys_order() @ 2022-07-13 02:03 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2022-07-13 02:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tidy up code in get_cheapest_group_keys_order() There are a few things that we could do a little better within get_cheapest_group_keys_order(): 1. We should be using list_free() rather than pfree() on a List. 2. We should use for_each_from() instead of manually coding a for loop to skip the first n elements of a List 3. list_truncate(list_copy(...), n) is not a great way to copy the first n elements of a list. Let's invent list_copy_head() for that. That way we don't need to copy the entire list just to truncate it directly afterwards. 4. We can simplify finding the cheapest cost by setting the cheapest cost variable to DBL_MAX. That allows us to skip special-casing the initial iteration of the loop. Author: David Rowley Discussion: https://postgr.es/m/CAApHDvrGyL3ft8waEkncG9y5HDMu5TFFJB1paoTC8zi9YK97Nw@mail.gmail.com Backpatch-through: 15, where get_cheapest_group_keys_order was added. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4cc832f94a583146fcf7886c9ce685894956d804 Modified Files -------------- src/backend/nodes/list.c | 21 +++++++++++++++++++++ src/backend/optimizer/path/pathkeys.c | 34 ++++++++++++++++++---------------- src/include/nodes/pg_list.h | 1 + 3 files changed, 40 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Tidy up code in get_cheapest_group_keys_order() @ 2022-07-13 02:03 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2022-07-13 02:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tidy up code in get_cheapest_group_keys_order() There are a few things that we could do a little better within get_cheapest_group_keys_order(): 1. We should be using list_free() rather than pfree() on a List. 2. We should use for_each_from() instead of manually coding a for loop to skip the first n elements of a List 3. list_truncate(list_copy(...), n) is not a great way to copy the first n elements of a list. Let's invent list_copy_head() for that. That way we don't need to copy the entire list just to truncate it directly afterwards. 4. We can simplify finding the cheapest cost by setting the cheapest cost variable to DBL_MAX. That allows us to skip special-casing the initial iteration of the loop. Author: David Rowley Discussion: https://postgr.es/m/CAApHDvrGyL3ft8waEkncG9y5HDMu5TFFJB1paoTC8zi9YK97Nw@mail.gmail.com Backpatch-through: 15, where get_cheapest_group_keys_order was added. Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/44b5d5625389c2e001e0ffe3d435c35965862adc Modified Files -------------- src/backend/nodes/list.c | 21 +++++++++++++++++++++ src/backend/optimizer/path/pathkeys.c | 34 ++++++++++++++++++---------------- src/include/nodes/pg_list.h | 1 + 3 files changed, 40 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-07-13 02:03 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-13 02:03 pgsql: Tidy up code in get_cheapest_group_keys_order() David Rowley <drowley@postgresql.org> 2022-07-13 02:03 pgsql: Tidy up code in get_cheapest_group_keys_order() David Rowley <drowley@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox