pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix for make unportability
Date: Wed, 13 Jul 2022 07:18:27 +0000
Message-ID: <E1oBWdd-002Yjy-Lt@gemulon.postgresql.org> (raw)

Fix for make unportability

88dad06b47eb80f699211c9b0b7a1c6d9016ad19 contains a make $(shell)
construct that apparently confuses older GNU make versions (possibly
because of the # inside the shell command?).  This construct, which
would allow # comments inside LINGUAS files, was adapted from gettext
recommendations, but we don't actually need that functionality, so
sidestep this whole issue by just using plain "cat".

In passing, make this code work with vpath.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/58b4f366c0c4b3a5d65269f01150e4ec04cb20a2

Modified Files
--------------
src/nls-global.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1oBWdd-002Yjy-Lt@gemulon.postgresql.org>
Permalink:  ../E1oBWdd-002Yjy-Lt@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oBWdd-002Yjy-Lt@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Fix for make unportability
  In-Reply-To: <E1oBWdd-002Yjy-Lt@gemulon.postgresql.org>
  References: <E1oBWdd-002Yjy-Lt@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox