pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix flag tests in src/test/modules/test_oat_hooks
Date: Wed, 13 Jul 2022 11:00:07 +0000
Message-ID: <E1oBa6A-002aGk-FT@gemulon.postgresql.org> (raw)

Fix flag tests in src/test/modules/test_oat_hooks

In what must have been a copy'n paste mistake, all the flag tests use
the same flag rather than a different flag each.  The bug is not
suprising, considering that it's dead code; add a minimal, testimonial
line to cover it.

This is all pretty inconsequential, because this is just example code,
but it had better be correct.

Discussion: https://postgr.es/m/20220712152059.fwli2majwgzdmh4r@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f16180216d0a6dcefd76fef4121227b63df46681

Modified Files
--------------
src/test/modules/test_oat_hooks/expected/test_oat_hooks.out | 13 ++++++++++++-
src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql      |  5 ++++-
src/test/modules/test_oat_hooks/test_oat_hooks.c            | 10 +++++-----
3 files changed, 21 insertions(+), 7 deletions(-)



Message-ID: <E1oBa6A-002aGk-FT@gemulon.postgresql.org>
Permalink:  ../E1oBa6A-002aGk-FT@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oBa6A-002aGk-FT@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Fix flag tests in src/test/modules/test_oat_hooks
  In-Reply-To: <E1oBa6A-002aGk-FT@gemulon.postgresql.org>
  References: <E1oBa6A-002aGk-FT@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox