From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use wildcards instead of manually-maintained file lists in */nls
Date: Wed, 13 Jul 2022 16:57:09 +0000
Message-ID: <E1oBfff-002eRi-Sq@gemulon.postgresql.org> (raw)
Use wildcards instead of manually-maintained file lists in */nls.mk.
The backend already used a mechanically-generated list of *.c files,
but everywhere else we had a manually-written-out list of files in
which to seek translatable messages. Commit b0a55e432 contains the
latest in a long line of failures to update those lists. Rather than
manually fix its oversight, let's change to using "$(wildcard *.c)"
in all these nls.mk files.
Many of these files also have manual references to some *.c files
in other directories, most often src/common/. Perhaps we should try
to improve that situation too; but it's a bit less clear how, so for
now just fix the local file references.
Kyotaro Horiguchi and Tom Lane
Discussion: https://postgr.es/m/20220713.160853.453362706160476128.horikyota.ntt@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/617d69141220f277170927e03a19d2f1b77aed77
Modified Files
--------------
src/bin/initdb/nls.mk | 2 +-
src/bin/pg_amcheck/nls.mk | 3 +--
src/bin/pg_archivecleanup/nls.mk | 2 +-
src/bin/pg_basebackup/nls.mk | 14 +-------------
src/bin/pg_checksums/nls.mk | 3 +--
src/bin/pg_config/nls.mk | 2 +-
src/bin/pg_controldata/nls.mk | 2 +-
src/bin/pg_ctl/nls.mk | 2 +-
src/bin/pg_dump/nls.mk | 8 +-------
src/bin/pg_resetwal/nls.mk | 2 +-
src/bin/pg_rewind/nls.mk | 2 +-
src/bin/pg_test_fsync/nls.mk | 2 +-
src/bin/pg_test_timing/nls.mk | 2 +-
src/bin/pg_upgrade/nls.mk | 4 +---
src/bin/pg_verifybackup/nls.mk | 4 +---
src/bin/pg_waldump/nls.mk | 2 +-
src/bin/psql/nls.mk | 6 +-----
src/bin/scripts/nls.mk | 7 +------
src/interfaces/ecpg/ecpglib/nls.mk | 2 +-
src/interfaces/ecpg/preproc/nls.mk | 2 +-
src/interfaces/libpq/nls.mk | 2 +-
src/pl/plperl/nls.mk | 2 +-
src/pl/plpgsql/src/nls.mk | 2 +-
src/pl/plpython/nls.mk | 3 +--
src/pl/tcl/nls.mk | 2 +-
25 files changed, 25 insertions(+), 59 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Use wildcards instead of manually-maintained file lists in */nls
In-Reply-To: <E1oBfff-002eRi-Sq@gemulon.postgresql.org>
References: <E1oBfff-002eRi-Sq@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox