pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make dsm_impl_posix_resize more future-proof.
Date: Sat, 16 Jul 2022 00:29:30 +0000
Message-ID: <E1oCVgX-000OpE-Lv@gemulon.postgresql.org> (raw)

Make dsm_impl_posix_resize more future-proof.

Commit 4518c798 blocks signals for a short region of code, but it
assumed that whatever called it had the signal mask set to UnBlockSig on
entry.  That may be true today (or may even not be, in extensions in the
wild), but it would be better not to make that assumption.  We should
save-and-restore the caller's signal mask.

The PG_SETMASK() portability macro couldn't be used for that, which is
why it wasn't done before.  But... considering that commit a65e0864
established back in 9.6 that supported POSIX systems have sigprocmask(),
and that this is POSIX-only code, there is no reason not to use standard
sigprocmask() directly to achieve that.

Back-patch to all supported releases, like 4518c798 and 80845b7c.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CA%2BhUKGKx6Biq7_UuV0kn9DW%2B8QWcpJC1qwhizdtD9tN-fn0H0g%40mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/91377a4559d8d8c0b119eb7dad97e11f3d566fcf

Modified Files
--------------
src/backend/storage/ipc/dsm_impl.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oCVgX-000OpE-Lv@gemulon.postgresql.org>
Permalink:  ../E1oCVgX-000OpE-Lv@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oCVgX-000OpE-Lv@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Make dsm_impl_posix_resize more future-proof.
  In-Reply-To: <E1oCVgX-000OpE-Lv@gemulon.postgresql.org>
  References: <E1oCVgX-000OpE-Lv@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox