pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Emulate sigprocmask(), not sigsetmask(), on Windows.
Date: Sat, 16 Jul 2022 05:09:35 +0000
Message-ID: <E1oCa3b-000Qjg-0k@gemulon.postgresql.org> (raw)

Emulate sigprocmask(), not sigsetmask(), on Windows.

Since commit a65e0864, we've required Unix systems to have
sigprocmask().  As noted in that commit's message, we were still
emulating the historical pre-standard sigsetmask() function in our
Windows support code.  Emulate standard sigprocmask() instead, for
consistency.

The PG_SETMASK() abstraction is now redundant and all calls could in
theory be replaced by plain sigprocmask() calls, but that isn't done by
this commit.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/3153247.1657834482%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c94ae9d827a360d74da6a304692d34a4dc8b6445

Modified Files
--------------
src/backend/port/win32/signal.c | 29 +++++++++++++++++++++++------
src/include/libpq/pqsignal.h    | 11 +++++++----
2 files changed, 30 insertions(+), 10 deletions(-)



Message-ID: <E1oCa3b-000Qjg-0k@gemulon.postgresql.org>
Permalink:  ../E1oCa3b-000Qjg-0k@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oCa3b-000Qjg-0k@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Emulate sigprocmask(), not sigsetmask(), on Windows.
  In-Reply-To: <E1oCa3b-000Qjg-0k@gemulon.postgresql.org>
  References: <E1oCa3b-000Qjg-0k@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox