pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Disable unstable test cases in src/test/ssl/t/001_ssltests.pl.
Date: Sat, 16 Jul 2022 22:26:32 +0000
Message-ID: <E1oCqF5-000Xlz-CZ@gemulon.postgresql.org> (raw)

Disable unstable test cases in src/test/ssl/t/001_ssltests.pl.

Some of the test cases added by commit 3a0e38504 are failing
intermittently in CI testing.  It looks like, when a connection
attempt fails, it's possible for psql to exit and the test script
to slurp up the postmaster's log file before the connected backend
has managed to write the log entry we're expecting to see.

It's not clear whether that's fixable in any robust way.  Pending
more thought, just comment out the log_like checks.  The ones in
connect_ok tests should be fine, since surely the log entry should
be emitted before we complete the client auth sequence.  I took
out all the ones in connect_fails tests though.

Discussion: https://postgr.es/m/E1oCNLk-000LCH-Af@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55828a6b6084724b08675615a4e911ad4d421cd1

Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 45 +++++++++++++++++++++++++-----------------
1 file changed, 27 insertions(+), 18 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oCqF5-000Xlz-CZ@gemulon.postgresql.org>
Permalink:  ../E1oCqF5-000Xlz-CZ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oCqF5-000Xlz-CZ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Disable unstable test cases in src/test/ssl/t/001_ssltests.pl.
  In-Reply-To: <E1oCqF5-000Xlz-CZ@gemulon.postgresql.org>
  References: <E1oCqF5-000Xlz-CZ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox