pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t
Date: Mon, 18 Jul 2022 18:45:33 +0000
Message-ID: <E1oDVkJ-0009cH-VZ@gemulon.postgresql.org> (raw)

Deal with paths containing \ and spaces in basebackup_to_shell tests

As $gzip is embedded in postgresql.conf \ needs to be escaped, otherwise guc.c
will take it as a string escape. Similarly, if "$gzip" contains spaces, the
prior incantation will fail. Both of these are common on windows.

Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/ce1b6eb3-5736-6f38-9775-b7020128b8d8@enterprisedb.com
Backpatch: 15-, where the test was added in 027fa0fd726

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a91242b1bcb312d6f482a758a432a32bd375896e

Modified Files
--------------
contrib/basebackup_to_shell/t/001_basic.pl | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oDVkJ-0009cH-VZ@gemulon.postgresql.org>
Permalink:  ../E1oDVkJ-0009cH-VZ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oDVkJ-0009cH-VZ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t
  In-Reply-To: <E1oDVkJ-0009cH-VZ@gemulon.postgresql.org>
  References: <E1oDVkJ-0009cH-VZ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox