pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t
2+ messages / 1 participants
[nested] [flat]

* pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t
@ 2022-07-18 18:45 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2022-07-18 18:45 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Deal with paths containing \ and spaces in basebackup_to_shell tests

As $gzip is embedded in postgresql.conf \ needs to be escaped, otherwise guc.c
will take it as a string escape. Similarly, if "$gzip" contains spaces, the
prior incantation will fail. Both of these are common on windows.

Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/ce1b6eb3-5736-6f38-9775-b7020128b8d8@enterprisedb.com
Backpatch: 15-, where the test was added in 027fa0fd726

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a91242b1bcb312d6f482a758a432a32bd375896e

Modified Files
--------------
contrib/basebackup_to_shell/t/001_basic.pl | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t
@ 2022-07-18 18:45 Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2022-07-18 18:45 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Deal with paths containing \ and spaces in basebackup_to_shell tests

As $gzip is embedded in postgresql.conf \ needs to be escaped, otherwise guc.c
will take it as a string escape. Similarly, if "$gzip" contains spaces, the
prior incantation will fail. Both of these are common on windows.

Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/ce1b6eb3-5736-6f38-9775-b7020128b8d8@enterprisedb.com
Backpatch: 15-, where the test was added in 027fa0fd726

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1ab07198363744eea5620d964570e674dc7eeb52

Modified Files
--------------
contrib/basebackup_to_shell/t/001_basic.pl | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-07-18 18:45 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 18:45 pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t Andres Freund <andres@anarazel.de>
2022-07-18 18:45 pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t Andres Freund <andres@anarazel.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox