pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add output file argument to generate-errcodes.pl
Date: Mon, 18 Jul 2022 19:56:18 +0000
Message-ID: <E1oDWqn-000ADM-Q9@gemulon.postgresql.org> (raw)

Add output file argument to generate-errcodes.pl

This is in preparation for building postgres with meson / ninja.

meson's 'capture' (redirecting stdout to a file) is a bit slower than programs
redirecting output themselves (mostly due to a python wrapper necessary for
windows). That doesn't matter for most things, but errcodes.h is a dependency
of nearly everything, making it a bit faster seem worthwhile.

Medium term it might also be worth avoiding writing errcodes.h if its contents
didn't actually change, to avoid unnecessary recompilations.

Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/5e216522-ba3c-f0e6-7f97-5276d0270029@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2bf626b714b5189d6041c228f74cdb769ea169fa

Modified Files
--------------
src/backend/utils/Makefile             |  2 +-
src/backend/utils/generate-errcodes.pl | 30 +++++++++++++++++++++++++-----
src/tools/msvc/Solution.pm             |  2 +-
3 files changed, 27 insertions(+), 7 deletions(-)



Message-ID: <E1oDWqn-000ADM-Q9@gemulon.postgresql.org>
Permalink:  ../E1oDWqn-000ADM-Q9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oDWqn-000ADM-Q9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Add output file argument to generate-errcodes.pl
  In-Reply-To: <E1oDWqn-000ADM-Q9@gemulon.postgresql.org>
  References: <E1oDWqn-000ADM-Q9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox