pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ecpg: use our instead of my in parse.pl to fix perlcritic compla
Date: Mon, 18 Jul 2022 21:55:28 +0000
Message-ID: <E1oDYi7-000B0F-Hq@gemulon.postgresql.org> (raw)

ecpg: use our instead of my in parse.pl to fix perlcritic complaint

In db0a272d123 I used open(our $something, ...), which perlcritic doesn't
like. It looks like the warning is due to perlcritic knowing about 'my' but
not 'our' when checking for bareword file handles.

However, it's clearly unnecessary to use "our" here, change it to "my".

Via buildfarm member crake and discussion with Tom Lane.

Discussion: https://postgr.es/m/20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d268d0f7a16e9e3c6de660b73543d875b8187def

Modified Files
--------------
src/interfaces/ecpg/preproc/parse.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1oDYi7-000B0F-Hq@gemulon.postgresql.org>
Permalink:  ../E1oDYi7-000B0F-Hq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oDYi7-000B0F-Hq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: ecpg: use our instead of my in parse.pl to fix perlcritic compla
  In-Reply-To: <E1oDYi7-000B0F-Hq@gemulon.postgresql.org>
  References: <E1oDYi7-000B0F-Hq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox