pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Dump more fields when dumping planner internal data structures.
Date: Wed, 20 Jul 2022 17:54:58 +0000
Message-ID: <E1oEDuT-000SOu-1W@gemulon.postgresql.org> (raw)

Dump more fields when dumping planner internal data structures.

Commit 964d01ae9 marked a lot of fields as read_write_ignore
to stay consistent with what was dumped by the manually-maintained
outfuncs.c code.  However, it seems that a pretty fair number
of those omissions were either flat-out oversights, or a shortcut
taken because hand-written code seemed like it'd be too much trouble.
Let's upgrade things where it seems to make sense to dump.

To do this, we need to add support to gen_node_support.pl and
outfuncs.c for variable-length arrays of Node pointers.  That's
pretty straightforward given the model of the existing code
for arrays of scalars, but I found I needed to tighten the
type-recognizing regexes in gen_node_support.pl.  (As they
stood, they mistook "foo **" for "foo *".  Make sure they're
all fully anchored to prevent additional problems.)

The main thing left un-done here is that a lot of partitioning-related
structs are still not dumped, because they are bare structs not Nodes.
I'm not sure about the wisdom of that choice ... but changing it would
be fairly invasive, so it probably requires more justification than
just making planner node dumps more complete.

Discussion: https://postgr.es/m/1295668.1658258637@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/af119e08fd147e808927b1a4c9f091636d52eb45

Modified Files
--------------
src/backend/nodes/gen_node_support.pl | 68 ++++++++++++++++++---------
src/backend/nodes/outfuncs.c          | 28 +++++++++++
src/include/nodes/pathnodes.h         | 88 +++++++++++++++++++----------------
3 files changed, 123 insertions(+), 61 deletions(-)



Message-ID: <E1oEDuT-000SOu-1W@gemulon.postgresql.org>
Permalink:  ../E1oEDuT-000SOu-1W@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oEDuT-000SOu-1W@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Dump more fields when dumping planner internal data structures.
  In-Reply-To: <E1oEDuT-000SOu-1W@gemulon.postgresql.org>
  References: <E1oEDuT-000SOu-1W@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox