pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove unnecessary Windows-specific basebackup code. 2+ messages / 1 participants [nested] [flat]
* pgsql: Remove unnecessary Windows-specific basebackup code. @ 2022-07-22 05:43 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Thomas Munro @ 2022-07-22 05:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unnecessary Windows-specific basebackup code. Commit c6f2f016 added an explicit check for a Windows "junction point". That turned out to be needed only because get_dirent_type() was busted on Windows. It's been fixed by commit 9d3444dc, so remove it. Add a TAP-test to demonstrate that in-place tablespaces are copied by pg_basebackup. This exercises the codepath that would fail before c6f2f016 on Windows, and shows that it still doesn't fail now that we're using get_dirent_type() on both Windows and Unix. Back-patch to 15, where in-place tablespaces arrived and caused this problem (ie directories where previously only symlinks were expected). Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKGLzLK4PUPx0_AwXEWXOYAejU%3D7XpxnYE55Y%2Be7hB2N3FA%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5344723755bdbb13d5271ccea181166327c63e97 Modified Files -------------- src/backend/access/transam/xlog.c | 5 ----- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 17 +++++++++++++++++ 2 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Remove unnecessary Windows-specific basebackup code. @ 2022-07-22 05:43 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Thomas Munro @ 2022-07-22 05:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unnecessary Windows-specific basebackup code. Commit c6f2f016 added an explicit check for a Windows "junction point". That turned out to be needed only because get_dirent_type() was busted on Windows. It's been fixed by commit 9d3444dc, so remove it. Add a TAP-test to demonstrate that in-place tablespaces are copied by pg_basebackup. This exercises the codepath that would fail before c6f2f016 on Windows, and shows that it still doesn't fail now that we're using get_dirent_type() on both Windows and Unix. Back-patch to 15, where in-place tablespaces arrived and caused this problem (ie directories where previously only symlinks were expected). Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKGLzLK4PUPx0_AwXEWXOYAejU%3D7XpxnYE55Y%2Be7hB2N3FA%40mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/202b56ba91cb6c0741cc9340ac57a50dbcdac549 Modified Files -------------- src/backend/access/transam/xlog.c | 5 ----- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 17 +++++++++++++++++ 2 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-07-22 05:43 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-22 05:43 pgsql: Remove unnecessary Windows-specific basebackup code. Thomas Munro <tmunro@postgresql.org> 2022-07-22 05:43 pgsql: Remove unnecessary Windows-specific basebackup code. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox